1
0

Improve exception handling patterns

- Replace bare except with specific Exception in git_repo.py
- Use try/except/else pattern for better flow in git_repo.py
- Replace logger.error with logger.exception in main.py for better error reporting

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
This commit is contained in:
Jon Michael Aanes 2025-06-25 00:22:49 +02:00
parent b79ea804b2
commit 36ba48f36e
2 changed files with 4 additions and 3 deletions

View File

@ -13,9 +13,10 @@ logger = logging.getLogger(__name__)
def determine_default_branch(repo: git.Repo): def determine_default_branch(repo: git.Repo):
try: try:
repo.commit('main') repo.commit('main')
return 'main' except Exception:
except:
return 'master' return 'master'
else:
return 'main'
def determine_project_name(repo: git.Repo) -> str: def determine_project_name(repo: git.Repo) -> str:

View File

@ -144,7 +144,7 @@ def main(
del result del result
except requests.exceptions.HTTPError as e: except requests.exceptions.HTTPError as e:
logger.exception('Failed in running %s', scraper_cls.__name__) logger.exception('Failed in running %s', scraper_cls.__name__)
logger.error('User-Agent: %s', e.request.headers['user-agent']) logger.exception('User-Agent: %s', e.request.headers['user-agent'])
continue continue
status = util.extend_csv_file( status = util.extend_csv_file(
OUTPUT_PATH / f'{scraper.dataset_name}.csv', OUTPUT_PATH / f'{scraper.dataset_name}.csv',