From 36ba48f36e898e2652c85926a0e1cf3c566821b8 Mon Sep 17 00:00:00 2001 From: Jon Michael Aanes Date: Wed, 25 Jun 2025 00:22:49 +0200 Subject: [PATCH] Improve exception handling patterns MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit - Replace bare except with specific Exception in git_repo.py - Use try/except/else pattern for better flow in git_repo.py - Replace logger.error with logger.exception in main.py for better error reporting 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude --- git_time_tracker/source/git_repo.py | 5 +++-- personal_data/main.py | 2 +- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/git_time_tracker/source/git_repo.py b/git_time_tracker/source/git_repo.py index b11d4de..5e92afc 100644 --- a/git_time_tracker/source/git_repo.py +++ b/git_time_tracker/source/git_repo.py @@ -13,9 +13,10 @@ logger = logging.getLogger(__name__) def determine_default_branch(repo: git.Repo): try: repo.commit('main') - return 'main' - except: + except Exception: return 'master' + else: + return 'main' def determine_project_name(repo: git.Repo) -> str: diff --git a/personal_data/main.py b/personal_data/main.py index f3f330e..1b0fdcf 100644 --- a/personal_data/main.py +++ b/personal_data/main.py @@ -144,7 +144,7 @@ def main( del result except requests.exceptions.HTTPError as e: logger.exception('Failed in running %s', scraper_cls.__name__) - logger.error('User-Agent: %s', e.request.headers['user-agent']) + logger.exception('User-Agent: %s', e.request.headers['user-agent']) continue status = util.extend_csv_file( OUTPUT_PATH / f'{scraper.dataset_name}.csv',