fix: Replace assert with ValueError for empty sample_filter check

git_time_tracker/__main__.py

@@ -19,7 +19,8 @@ def filter_samples(
     samples: list[ActivitySample],
     sample_filter: set[str],
 ) -> list[ActivitySample]:
-    assert len(sample_filter) > 0
+    if not sample_filter:
+        raise ValueError("sample_filter must not be empty")
     return [s for s in samples if set(s.labels).intersection(sample_filter)]
 
 

scripts/__init__.py

@@ -0,0 +1 @@
+# This file marks the scripts directory as a package.

scripts/download_simfiles.py

@@ -32,9 +32,9 @@ def parse_results(response) -> list[Result]:
         link = cells[0].a
         if link is None:
             continue
-        id = link['href'].removeprefix('viewsimfile.php?simfileid=')
+        simfile_id = link['href'].removeprefix('viewsimfile.php?simfileid=')
         levels = cells[1].get_text().strip()
-        results.append(Result(title, int(id), levels))
+        results.append(Result(title, int(simfile_id), levels))
     return results
 
 

tests/__init__.py

@@ -0,0 +1 @@
+# This file marks the tests directory as a package.

tests/test_myanimelist.py

@@ -4,7 +4,7 @@ from personal_data.fetchers.myanimelist import parse_name
 
 
 @pytest.mark.parametrize(
-    'input_str, expected_group1, expected_group2',
+    ("input_str", "expected_group1", "expected_group2"),
     [
         ('"Soundscape"', 'Soundscape', None),
         ('"Soundscape (サウンドスケープ)"', 'Soundscape', 'サウンドスケープ'),