fin_depo/defi_kraken.py

@@ -7,14 +7,7 @@ from decimal import Decimal
 import fin_defs
 import krakenex
 
-from .data import (
-    DepoFetcher,
-    DepoSingle,
-    DepositDetails,
-    DoubleRegister,
-    TradeOrderDetails,
-    WithdrawalDetails,
-)
+from .data import Depo, DepoFetcher, DepoSingle
 
 logger = logging.getLogger(__name__)
 
@@ -63,23 +56,6 @@ class KrakenDepoFetcher(DepoFetcher):
         )
 
 
-    def _get_withdrawals(self) -> list[WithdrawalDetails]:
-        raise NotImplementedError("_get_withdrawals is a work in progress")
-
-    def _get_deposits(self) -> list[DepositDetails]:
-        raise NotImplementedError("_get_deposits is a work in progress")
-
-    def _get_historic_spot_orders(self) -> Iterator[TradeOrderDetails]:
-        raise NotImplementedError("_get_historic_spot_orders is a work in progress")
-
-    def _get_double_registers(self) -> list[DoubleRegister]:
-        double_registers: list[DoubleRegister] = []
-        double_registers += self._get_deposits()
-        double_registers += self._get_withdrawals()
-        double_registers += self._get_historic_spot_orders()
-        double_registers.sort(key=lambda x: x.executed_time)
-        return double_registers
-
 def parse_asset_from_ticker(ticker: str) -> fin_defs.Asset:
     account = ticker.removesuffix('.HOLD')
     if account == 'ZEUR':

fin_depo/defi_kucoin.py

@@ -242,16 +242,9 @@ class KucoinDepoFetcher(DepoFetcher):
         for _weeks_back in range(20):
             end_time = end_time - datetime.timedelta(days=7)
             timestamp = int(end_time.timestamp() * 1000)
-            page_index = 1
-            while True:
-                raw_details = self.kucoin_client.get_orders(end=timestamp, page=page_index)
-                yield from (order_from_json(item) for item in raw_details['items'])
-
-                page_index = raw_details['currentPage'] + 1
-                if page_index > raw_details['totalPage']:
-                    break
-                del raw_details
-            del _weeks_back
+            raw_details = self.kucoin_client.get_orders(end=timestamp)
+            yield from (order_from_json(item) for item in raw_details['items'])
+            del _weeks_back, raw_details
 
     def _get_double_registers(self) -> list[DoubleRegister]:
         double_registers: list[DoubleRegister] = []