Jmaa/fin-defs
1
0
Fork 0
Code Actions Packages

Turns out: The CCXT ids can be literally anything
All checks were successful
Python Ruff Code Quality / ruff (push) Successful in 23s
Details
Run Python tests (through Pytest) / Test (push) Successful in 25s
Details
Verify Python project can be installed, loaded and have version checked / Test (push) Successful in 22s
Details

Browse Source
This commit is contained in:
Jon Michael Aanes 2024-11-15 10:59:13 +01:00
parent 3151b2ee89
commit 3a2b7ebd25
Signed by: Jmaa
SSH Key Fingerprint: SHA256:Ab0GfHGCblESJx7JRE4fj4bFy/KRpeLhi41y4pF3sNA
2 changed files with 1 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
fin_defs/__init__.py
View File

@ -268,11 +268,6 @@ class CryptoCurrency(Currency):
ccxt_symbol: str ccxt_symbol: str
coingecko_id: str | None = None coingecko_id: str | None = None
def __post_init__(self) -> None:
if not re.match(r'^\S.*\S$', self.ccxt_symbol):
msg = f'ccxt_symbol was not in correct format: {self.ccxt_symbol}'
raise ValueError(msg)
def raw_short_name(self) -> str: def raw_short_name(self) -> str:
return self.ccxt_symbol return self.ccxt_symbol

2
test/test_ids.py
View File

@ -17,6 +17,7 @@ VALID_IDS = [
'crypto:LOLCOIN', 'crypto:LOLCOIN',
'commodity:ALUMINUM', 'commodity:ALUMINUM',
'unknown:XXX', 'unknown:XXX',
'crypto: ', # CCXT actually found one with only whitespace. Why?
] ]
@ -41,7 +42,6 @@ INVALID_IDS = [
'fiat:TEST:TEST', 'fiat:TEST:TEST',
'index:TEST:TEST', 'index:TEST:TEST',
'commodity:TEST:TEST', 'commodity:TEST:TEST',
'crypto: ',
'!!!!', '!!!!',
'::::', '::::',
'', '',