refactor: handle PR comments only after marking issues as seen

Initial ruff pass
2025-04-23 22:25:47 +02:00 · 2025-04-23 22:24:47 +02:00
1 changed files with 14 additions and 23 deletions
--- a/aider_gitea/init.py
+++ b/aider_gitea/init.py
@ -495,9 +495,6 @@ def solve_issues_in_repository(
        logger.info('No issues found for %s', repository_config.repo)
        return

-    # batch up PRs to handle comments after all issues are resolved
-    jobs: list[tuple[str, str, str]] = []
-
    for issue in issues:
        issue_url = issue.get('web_url')
        issue_number = issue.get('number')
@ -518,29 +515,23 @@ def solve_issues_in_repository(
                issue_number,
                client,
            )
-            if issue_resolution.success:
-                # defer comment handling until after all issues complete
-                jobs.append((issue_url, issue_resolution.pull_request_id, branch_name))
-                seen_issues_db.mark_as_seen(issue_url, str(issue_number))
-                seen_issues_db.update_pr_info(
-                    issue_url,
-                    issue_resolution.pull_request_id,
-                    issue_resolution.pull_request_url,
-                )
-                logger.info(
-                    'Stored PR #%s information for issue #%s',
-                    issue_resolution.pull_request_id,
-                    issue_number,
-                )

-    # once all new issues are done, process any PR comments in batch
-    for issue_url, pr_id, branch_name in jobs:
-        with tempfile.TemporaryDirectory() as repository_path:
-            run_cmd(['git', 'clone', repository_config.repo_url(), repository_path])
-            run_cmd(['git', 'checkout', branch_name], repository_path)
+        if issue_resolution.success:
+            seen_issues_db.mark_as_seen(issue_url, str(issue_number))
+            seen_issues_db.update_pr_info(
+                issue_url,
+                issue_resolution.pull_request_id,
+                issue_resolution.pull_request_url,
+            )
+            logger.info(
+                'Stored PR #%s information for issue #%s',
+                issue_resolution.pull_request_id,
+                issue_number,
+            )
+            # Handle unresolved pull request comments
            handle_pr_comments(
                repository_config,
-                pr_id,
+                issue_resolution.pull_request_id,
                branch_name,
                Path(repository_path),
                client,
Author	SHA1	Message	Date
Jon Michael Aanes (aider)	5595c0bbca	refactor: handle PR comments only after marking issues as seen All checks were successful Run Python tests (through Pytest) / Test (push) Successful in 26s Details Verify Python project can be installed, loaded and have version checked / Test (push) Successful in 22s Details	2025-04-23 22:25:47 +02:00
Jon Michael Aanes	f9a13896f9	Initial ruff pass	2025-04-23 22:24:47 +02:00