Compare commits
3 Commits
00678b46e2
...
0b40e8dec9
Author | SHA1 | Date | |
---|---|---|---|
0b40e8dec9 | |||
b743fd0afb | |||
2e32d5a31b |
|
@ -757,8 +757,8 @@ def solve_issues_in_repository(
|
|||
issue_number,
|
||||
)
|
||||
|
||||
# Handle unresolved pull request comments
|
||||
if True:
|
||||
# TODO: PR comment handling disabled for now due to missing functionality
|
||||
if False:
|
||||
# Handle unresolved pull request comments
|
||||
handle_pr_comments(
|
||||
repository_config,
|
||||
|
|
|
@ -220,89 +220,108 @@ class GiteaClient:
|
|||
response.raise_for_status()
|
||||
return response.json()
|
||||
|
||||
def get_pull_request_comments(
|
||||
def get_pull_request_reviews(
|
||||
self,
|
||||
owner: str,
|
||||
repo: str,
|
||||
pr_number: int,
|
||||
pull_number: int,
|
||||
) -> list[dict]:
|
||||
"""Fetch all review comments for a pull request.
|
||||
|
||||
This method implements the flow:
|
||||
1. Download all reviews of the pull request
|
||||
2. Download all comments for each review
|
||||
3. Return all comments in a unified format
|
||||
"""Fetch all reviews for a specific pull request.
|
||||
|
||||
Args:
|
||||
owner (str): Owner of the repository.
|
||||
repo (str): Name of the repository.
|
||||
pr_number (int): Pull request number.
|
||||
pull_number (int): Pull request number.
|
||||
|
||||
Returns:
|
||||
list[dict]: List of comment dictionaries with keys:
|
||||
- id: Comment ID
|
||||
- body: Comment body text
|
||||
- path: File path the comment refers to
|
||||
- line: Line number (or position)
|
||||
- user: User who made the comment
|
||||
list[dict]: List of review dictionaries.
|
||||
|
||||
Raises:
|
||||
requests.HTTPError: If the API request fails.
|
||||
"""
|
||||
url = f'{self.gitea_url}/repos/{owner}/{repo}/pulls/{pull_number}/reviews'
|
||||
response = self.session.get(url)
|
||||
response.raise_for_status()
|
||||
return response.json()
|
||||
|
||||
def get_review_comments(
|
||||
self,
|
||||
owner: str,
|
||||
repo: str,
|
||||
pull_number: int,
|
||||
review_id: int,
|
||||
) -> list[dict]:
|
||||
"""Fetch all comments for a specific review.
|
||||
|
||||
Args:
|
||||
owner (str): Owner of the repository.
|
||||
repo (str): Name of the repository.
|
||||
pull_number (int): Pull request number.
|
||||
review_id (int): Review ID.
|
||||
|
||||
Returns:
|
||||
list[dict]: List of comment dictionaries.
|
||||
|
||||
Raises:
|
||||
requests.HTTPError: If the API request fails.
|
||||
"""
|
||||
url = f'{self.gitea_url}/repos/{owner}/{repo}/pulls/{pull_number}/reviews/{review_id}/comments'
|
||||
response = self.session.get(url)
|
||||
response.raise_for_status()
|
||||
return response.json()
|
||||
|
||||
def get_pull_request_comments(
|
||||
self,
|
||||
owner: str,
|
||||
repo: str,
|
||||
pull_number: int,
|
||||
) -> list[dict]:
|
||||
"""Fetch all comments for a pull request by downloading all reviews and their comments.
|
||||
|
||||
This method implements the flow:
|
||||
1. Download all reviews of the pull request
|
||||
2. Download all comments for each review
|
||||
3. Return all comments from all reviews
|
||||
|
||||
Args:
|
||||
owner (str): Owner of the repository.
|
||||
repo (str): Name of the repository.
|
||||
pull_number (int): Pull request number.
|
||||
|
||||
Returns:
|
||||
list[dict]: List of all comment dictionaries from all reviews.
|
||||
|
||||
Raises:
|
||||
requests.HTTPError: If the API request fails.
|
||||
"""
|
||||
all_comments = []
|
||||
|
||||
# First, get all reviews for the pull request
|
||||
reviews_url = f'{self.gitea_url}/repos/{owner}/{repo}/pulls/{pr_number}/reviews'
|
||||
reviews_response = self.session.get(reviews_url)
|
||||
reviews_response.raise_for_status()
|
||||
reviews = reviews_response.json()
|
||||
# Download all reviews of the pull request
|
||||
reviews = self.get_pull_request_reviews(owner, repo, pull_number)
|
||||
|
||||
# For each review, get all comments
|
||||
# Download all comments for each review
|
||||
for review in reviews:
|
||||
review_id = review.get('id')
|
||||
if not review_id:
|
||||
continue
|
||||
|
||||
# Get comments for this specific review
|
||||
comments_url = f'{self.gitea_url}/repos/{owner}/{repo}/pulls/{pr_number}/reviews/{review_id}/comments'
|
||||
comments_response = self.session.get(comments_url)
|
||||
comments_response.raise_for_status()
|
||||
comments = comments_response.json()
|
||||
|
||||
# Add each comment to our collection
|
||||
all_comments.extend(
|
||||
[
|
||||
{
|
||||
'id': comment.get('id'),
|
||||
'body': comment.get('body', ''),
|
||||
'path': comment.get('path', ''),
|
||||
'line': comment.get('line') or comment.get('position') or 0,
|
||||
'user': comment.get('user', {}).get('login', ''),
|
||||
'review_id': review_id,
|
||||
}
|
||||
for comment in comments
|
||||
],
|
||||
)
|
||||
|
||||
# Also get general PR comments (not tied to specific reviews)
|
||||
general_comments_url = (
|
||||
f'{self.gitea_url}/repos/{owner}/{repo}/pulls/{pr_number}/comments'
|
||||
)
|
||||
general_response = self.session.get(general_comments_url)
|
||||
general_response.raise_for_status()
|
||||
general_comments = general_response.json()
|
||||
|
||||
# Add general comments that have file/line info
|
||||
all_comments.extend(
|
||||
[
|
||||
{
|
||||
'id': comment.get('id'),
|
||||
'body': comment.get('body', ''),
|
||||
'path': comment.get('path', ''),
|
||||
'line': comment.get('line') or comment.get('position') or 0,
|
||||
'user': comment.get('user', {}).get('login', ''),
|
||||
'review_id': None, # General comments don't belong to a specific review
|
||||
}
|
||||
for comment in general_comments
|
||||
if comment.get('path') # Only include comments with file references
|
||||
],
|
||||
)
|
||||
if review_id:
|
||||
try:
|
||||
comments = self.get_review_comments(
|
||||
owner,
|
||||
repo,
|
||||
pull_number,
|
||||
review_id,
|
||||
)
|
||||
# Add review context to each comment for better debugging
|
||||
for comment in comments:
|
||||
comment['review_id'] = review_id
|
||||
comment['review_state'] = review.get('state')
|
||||
all_comments.extend(comments)
|
||||
except requests.RequestException as e:
|
||||
# Log the error but continue processing other reviews
|
||||
logger.warning(
|
||||
'Failed to get comments for review %s in PR %s: %s',
|
||||
review_id,
|
||||
pull_number,
|
||||
e,
|
||||
)
|
||||
|
||||
return all_comments
|
||||
|
|
|
@ -69,9 +69,10 @@ class TestClaudeCodeIntegration:
|
|||
'claude',
|
||||
'-p',
|
||||
'--output-format',
|
||||
'json',
|
||||
'--max-turns',
|
||||
'10',
|
||||
'stream-json',
|
||||
'--debug',
|
||||
'--verbose',
|
||||
'--dangerously-skip-permissions',
|
||||
issue,
|
||||
]
|
||||
assert cmd == expected
|
||||
|
@ -84,9 +85,10 @@ class TestClaudeCodeIntegration:
|
|||
'claude',
|
||||
'-p',
|
||||
'--output-format',
|
||||
'json',
|
||||
'--max-turns',
|
||||
'10',
|
||||
'stream-json',
|
||||
'--debug',
|
||||
'--verbose',
|
||||
'--dangerously-skip-permissions',
|
||||
'--model',
|
||||
'claude-3-sonnet',
|
||||
issue,
|
||||
|
|
Loading…
Reference in New Issue
Block a user